Italian translation of the hub #1290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sebastiano Ballotta <sebeballotta@outlook.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@rinodrummer Apologies for the late review. This looks good, but I can see 6 TODOs outstanding in the code that will need addressing before this can be merged. Thanks. |
|
Hi @glennjacobs, I'll give a look at them in the weekend! |
Hi @rinodrummer, I'm going to change this PR to draft until we have it ready for review again. |
glennjacobs
added
i18n
|
I will look to merge translations once we've hit a beta release, as there may be some changes required. |
|
I've just realised I assumed this was for v1.0, but it's actually targeting 0.8. Would you have any interest in doing v1.0? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To improve the usability, me and @sebhd1 decided to dive in the Italian translation of the hub.
We translated all the entries in the localization files, but noticed that most of the UI components have un-wrapped texts that make them hard to translate.
I think that a guide line must be discussed to define which namespaces must be attributed to some components and must enforce to use
__()whenever possible, even in component labels, placeholders and so on when new hub section are introduced.We are willing to help and always open to discussions (which will handle here)!
References #1152.