Changed so error causes exit #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raginjason
force-pushed
the
exit_on_error
branch
from
e572e9d
to
8d36357
Compare
This was referenced Sep 6, 2019
romnn
pushed a commit
to romnn/pgfutter
that referenced
this pull request
Nov 20, 2019
Errors are properly logged to stderr and github.com/codegangsta/cli was replaced by github.com/urfave/cli. This includes the open pull request at lukasmartinelli#67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like at some point this check was removed. Adding it back.