Fix a pwdfield bug.

[Jo5629]

CODE:

local gui = flow.widgets

local title = gui.Label{label = "JBanking", align_h = "centre", style = {font = "bold", font_size = "*1.5"}}

jbanking.create_formspec = flow.make_gui(function(player, ctx)
    local buttons_hbox = gui.Hbox{}
    table.insert_all(buttons_hbox, {
        gui.Button{name = "signin", label = "Sign-In Portal", w = 3, h = 1.125,
        on_event = function(player, ctx)
            --jbanking.signin_formspec:show(player)
        end},
        gui.Spacer{},
        gui.Button{name = "new_account", label = "Create", w = 3, h = 1.125,
        on_event = function(player, ctx)
            minetest.chat_send_all(ctx.form["jbanking:username"] .. " | " .. ctx.form["jbanking:password"])
        end},
    })
    return gui.VBox{
        title,
        gui.Label{label = "Account Creation Portal", align_h = "centre", style = {font = "italic", font_size = "*1"}},
        gui.Field{name = "jbanking:username", label = "Username:", h = 1.125},
        gui.Pwdfield{name = "jbanking:password", label = "Password:", h = 1.125},
        buttons_hbox,
    }
end)

jbanking.create_formspec:show(player)

The formspec loads up correctly, but when I try to submit the form, the game crashes and says that there is no jbanking:password. When I change the type from gui.Pwdfield to gui.Field, the formspec runs as normal.

The PR should fix this.

[Lazerbeak12345]

this bit of advice isn't the cause of the bug (it looks like you're on the right page for fixing it, in fact) but I should point out that style[] elements don't play nice with formspec elements with colons (:) in their name

[Jo5629]

this bit of advice isn't the cause of the bug (it looks like you're on the right page for fixing it, in fact) but I should point out that style[] elements don't play nice with formspec elements with colons (:) in their name

Thanks for the info. They are like that because I didn't know what was wrong, so that is just from troubleshooting.

[luk3yx]

The fix seems reasonable, though sadly MT has no "default" value for pwdfield[] elements, so the value will be lost by the client if the form gets updated.

---

Something unrelated I've been meaning to bring up: Are you and @Lazerbeak12345 okay with me potentially relicensing flow (and your respective contributions) under LGPL v2.1+ at some point? Flow is currently LGPL v3+, but grorp has asked about using it in the main menu, so I'd like to be able to relicense it if anything more happens there.

I probably don't need permission to relicense small changes like this PR, but asking anyway seems like a good idea.

[luk3yx]

And thanks for your PR!

[Jo5629]

The fix seems reasonable, though sadly MT has no "default" value for pwdfield[] elements, so the value will be lost by the client if the form gets updated.

Something unrelated I've been meaning to bring up: Are you and @Lazerbeak12345 okay with me potentially relicensing flow (and your respective contributions) under LGPL v2.1+ at some point? Flow is currently LGPL v3+, but grorp has asked about using it in the main menu, so I'd like to be able to relicense it if anything more happens there.

I probably don't need permission to relicense small changes like this PR, but asking anyway seems like a good idea.

1. Yeah I am already experiencing that issue.
2. I am okay with your request.

[Lazerbeak12345]

Something unrelated I've been meaning to bring up: Are you and @Lazerbeak12345 okay with me potentially relicensing flow (and your respective contributions) under LGPL v2.1+ at some point? Flow is currently LGPL v3+, but grorp has asked about using it in the main menu, so I'd like to be able to relicense it if anything more happens there.

I probably don't need permission to relicense small changes like this PR, but asking anyway seems like a good idea.

A move to bring the licence to match Minetest seems fine to me. I'm alright if my contributions to flow are retroactively changed from LGPLv3_or_higher to LGPLv2.1_or__higher