Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing <cstdint> include to bdd.hpp :) #7

Merged

Conversation

bluebandit21
Copy link
Contributor

This header file uses uint32_t and such, but doesn't actually include / <stdint.h>

Some compilers (e.g. clang) automatically know about those types, but this causes problems on GCC.

@luigicapogrosso
Copy link
Owner

Hi @bluebandit21, thank you for noticing!

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@luigicapogrosso luigicapogrosso merged commit 52f968b into luigicapogrosso:main Mar 26, 2024
8 checks passed
@bluebandit21
Copy link
Contributor Author

Of course! :D

Glad I could help :)

I'm working with some other people on doing something interesting based on HermesBDD, so I'll definitely let you all know if we find anything interesting/there are other fixes/improvements I can make ❤️

@bluebandit21 bluebandit21 deleted the fix/missing_cstdint_include branch March 26, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants