Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes head creation on route globbing #68

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Fixes head creation on route globbing #68

merged 2 commits into from
Nov 12, 2024

Conversation

HarbinsonAdam
Copy link
Contributor

Fixes #67

@HarbinsonAdam HarbinsonAdam marked this pull request as draft November 12, 2024 09:14
@HarbinsonAdam HarbinsonAdam marked this pull request as ready for review November 12, 2024 09:24
jwoertink
jwoertink approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@jwoertink jwoertink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! Thanks for pushing a fix for this.

@jwoertink jwoertink merged commit abfc0b0 into luckyframework:main Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwoertink jwoertink jwoertink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route Globbing doesn't create HEAD
2 participants
@HarbinsonAdam @jwoertink