This repository has been archived by the owner on Mar 24, 2023. It is now read-only.
Tabbing accessibility improvements #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answers issue #143.
The goal of this PR is to allow keyboard users to operate the lightbox and gallery.
Adding hidden, focusable divs with the class
'.focus-bounds'along with some refs and aria-attributes provides a sensible tabbing order while not being too prescriptive. Any future additions made to the sections of the lightbox should not affect tabbing with the exception of the toolbar, where refs are used. Adding or re-ordering toolbar buttons could affect tab order but this could be solved by using querySelectors instead of refs and targeting the first/last toolbar button. Happy to make that change if you'd like.Also worth considering is adding
@keyup.enter="index = mediaIndex"alongside the@clicklistener in the examples on media items to be pulled into the lightbox. This allows the lightbox to be opened with a keyboard as well as a mouse.Big fan of this project and I hope I was able to help contribute to its success.
Cheers!