DM-42226: Write python package metadata #131
Open
+129
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows that a PKG-INFO file in the python/*.egg-info directory does work with importlib.metadata. This implementation needs to be cleaned up to not rely on an extra parameter.
This allows it to work without needing a new parameter for SCons initialization. There is a question as to whether this should be gated on whether the version target is going to be enabled or not.
3.10 does not include tomllib.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
=======================================
Coverage 85.36% 85.36%
=======================================
Files 5 5
Lines 41 41
Branches 3 3
=======================================
Hits 35 35
Misses 3 3
Partials 3 3 ☔ View full report in Codecov by Sentry. |
2 tasks
dist-info is the new standard and egg-info is deprecated. Change the directory name and PKG-INFO is now called METADATA.
SCons will clean up the files inside that directory automatically but will not delete the directory.
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This writes an egg-info directory into the python directory, enabling entry points and importlib.metadata to function using standard Python interfaces.