Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-43077: Convert all tasks to use CalibrateImageTask outputs #979

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

DM-43077: Convert all tasks to use CalibrateImageTask outputs #979

wants to merge 11 commits into from

Commits on Oct 10, 2024

  1. Switch to calibrateImage outputs

    @parejkoj @TallJimbo
    parejkoj authored and TallJimbo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d9a5dfe View commit details
    Browse the repository at this point in the history

  2. Deprecation questions

    @parejkoj @TallJimbo
    parejkoj authored and TallJimbo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a20203c View commit details
    Browse the repository at this point in the history

  3. Add sdm standardization file for calibrateImage output

    @parejkoj @TallJimbo
    parejkoj authored and TallJimbo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a939d4c View commit details
    Browse the repository at this point in the history

  4. Use regular column functor for id field 

    Now that reprocessVisitImage is directly writing an ArrowAstropy, it
no longer has an index column, so we can just treat the id like a normal
column.
    @parejkoj @TallJimbo
    parejkoj authored and TallJimbo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1df4911 View commit details
    Browse the repository at this point in the history

  5. Remove STREAK flag from sdm catalogs 

    They will get added back in once we start propagating them from the
diffim.
Remove STREAK from MeasureMergedCoaddSources.
    @parejkoj @TallJimbo
    parejkoj authored and TallJimbo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e3836da View commit details
    Browse the repository at this point in the history

  6. Remove calib_detected from sdm output 

    calib_detected is now meaningless, as the icSource table is no more.
    @parejkoj @TallJimbo
    parejkoj authored and TallJimbo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    eba22aa View commit details
    Browse the repository at this point in the history

  7. Remove initial PhotoCalib in finalizeCharacterization. 

    This is needed for compatibility with outputs produced by
CalibrateImageTask.
    @TallJimbo
    TallJimbo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    b2b2d95 View commit details
    Browse the repository at this point in the history

  8. Clean up MakeWarpTask docs and variable names. 

    Some doc parameter lists had gotten out of sync with the code, and it's
always good to clarify whether you've got a DeferredDatasetHandle or a
real object.
    @TallJimbo
    TallJimbo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    901f93c View commit details
    Browse the repository at this point in the history

  9. Apply calibration to warps after applying skyCorr backgrounds. 

    Background modeling is done on the image without the calibration
applied, and that's how it should be subtracted, too.

This was a clear bug in the old code, but probably a very minor one,
because the photometric calibration is close to constant, and we were
previously only incorrectly multiplying the skyCorr background by the
ratio of the photometric calibration to its average.
    @TallJimbo
    TallJimbo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ae0b327 View commit details
    Browse the repository at this point in the history

  10. Drop errant commas in docstring concatenation.

    @TallJimbo
    TallJimbo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    142eaf9 View commit details
    Browse the repository at this point in the history

  11. Remove initial PhotoCalib in makeWarp. 

    This is needed for compatibility with outputs produced by
CalibrateImageTask.
    @TallJimbo
    TallJimbo committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ddcd8c9 View commit details
    Browse the repository at this point in the history