Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-45576: Start a nightly cronjob to post a brief summary #3

Merged
merged 9 commits into from
Sep 28, 2024

Conversation

hsinfang
Copy link
Contributor

@hsinfang hsinfang commented Aug 2, 2024

No description provided.

@hsinfang hsinfang force-pushed the tickets/DM-45576 branch 2 times, most recently from 2476bcc to e0468ea Compare August 5, 2024 23:23
@hsinfang hsinfang force-pushed the tickets/DM-45576 branch 5 times, most recently from 4be20b9 to b5226fb Compare August 9, 2024 21:04
@hsinfang hsinfang force-pushed the tickets/DM-45576 branch 3 times, most recently from b0a4741 to ab85d84 Compare August 30, 2024 20:43
@hsinfang hsinfang requested a review from ctslater August 30, 2024 20:45
Copy link
Member

@ctslater ctslater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice additions to the script. I left just some minor comments.

scripts/utils.py Outdated Show resolved Hide resolved
scripts/prompt_processing_summary.py Outdated Show resolved Hide resolved
output_lines.append(f" - {counts} to be investigated.")

output_lines.append(
f"<https://usdf-rsp-dev.slac.stanford.edu/times-square/github/lsst-sqre/times-square-usdf/prompt-processing/groups?date={day_obs}&instrument=LATISS&survey={survey}&mode=DEBUG&ts_hide_code=1|Timing plots>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does &mode=DEBUG do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that Times Square notebook, written before we started making this reporting tool, I wanted a "report" mode versus a "debug" mode. The former is brief and meant for people who don't care about PP internals. The latter has a lot more details which the PP team can use to know what might have gone wrong. Now we have this reporting tool, I probably can go back and think again whether it makes sense.

@hsinfang hsinfang force-pushed the tickets/DM-45576 branch 2 times, most recently from 1141fb5 to 19caa35 Compare September 13, 2024 22:47
The number for single-frame-only processing as calculated here
can become wrong as the implementations change, but useful for
the time being.

Using the existence of initial_pvi as the ProcessCcd success
is confusing because calibrateImage can fail after generating
initial_pvi.

Using the last product of calibrateImage is not ideal either,
but a little closer.

Send message only if there are on-sky exposures.
can_see_sky started to be a useable criteria starting w_2024_33.
Using can_see_sky or science_program typically give the same results.
The name change happened on 2024-09-04
Starting w_2024_37, the new Butler query system becomes public.

Using explain=False so not to raise EmptyQueryResultError.
Now we also process some test surveys, constrain this report
to the science survey only.
@hsinfang hsinfang merged commit 9a051cb into main Sep 28, 2024
1 check passed
@hsinfang hsinfang deleted the tickets/DM-45576 branch September 28, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants