DM-46914: Demonstrate facility name mapping #23
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
=======================================
Coverage 82.29% 82.29%
=======================================
Files 18 18
Lines 1079 1079
Branches 174 174
=======================================
Hits 888 888
Misses 166 166
Partials 25 25 ☔ View full report in Codecov by Sentry. |
andy-slac
approved these changes
Dec 2, 2024
| facility_map: | ||
| LATISS: "Rubin:1.2m" | ||
| LSSTComCam: "Rubin:Simonyi" | ||
| LSSTCam: "Rubin:Simonyi" | ||
| # We don't explicitly specify instrument_name - it's auto-generated from the corresponding Butler dimension | ||
| obs_collection: LATISS_LIVE # may evolve as experience with this builds up |
There was a problem hiding this comment.
Would we need similar instrument-specific value for obs_collection?
There was a problem hiding this comment.
I think we might end up needing a obs_collection to Butler collection mapping here. cc/ @gpdf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lsst/daf_butler#1122