Temporary branch for Stelios to test SIAv2 from #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comes from sdm_schemas
Uses felis to describe the table metadata.
Supports POS, BAND, TIME, INSTRUMENT
Now track the WHERE and bind information discretely and combine as needed.
Use WhereBind class to specify the specific query for export.
This will allow in the future a handler that doesn't use the default dimension universe.
* SIAv2Parameters parses the standard parameters into Python form. * Interval represents a floating point interval such as that used by BAND and TIME.
Was region_dim and timespan_dim, now region_dimension and timespan_dimension and they return str | None.
* Can now specify multiple --pos --time etc on command-line * Can now call the query API with a pre-parsed SIAv2Parameters
Butler query system can not OR together regions but sphgeom can. This does require some fixes in sphgeom itself before it can work (DM-46239).
This allows exposure regions to be checked.
Use an updated form of the ci_hsc_gen3 yaml export so that we can do a direct comparison with an actual repo using the command line.
Remove a dependency on SqlRegistry in ObscoreExporter, to allow it to work with RemoteButler.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
===========================================
+ Coverage 62.07% 81.86% +19.78%
===========================================
Files 11 15 +4
Lines 472 1020 +548
Branches 108 262 +154
===========================================
+ Hits 293 835 +542
+ Misses 169 163 -6
- Partials 10 22 +12 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a merge of DM-46363 with DM-45860 and depends on unreleased changes in daf_butler DM-46363