Skip to content

Commit

Permalink
Add code inspection to LVV-T1746 NB
Browse files Browse the repository at this point in the history
  • Loading branch information
jeffcarlin committed Oct 9, 2024
1 parent eb7817f commit 8ecd7a0
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion notebooks/test_LVV-T1746.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -432,13 +432,30 @@
"Image(\"figures/chronograf_AF1_history_jul2023_oct2024.png\", width=600)"
]
},
{
"cell_type": "markdown",
"id": "a6b04198-f364-40c6-a794-c08f6a3567c6",
"metadata": {},
"source": [
"### Thresholds\n",
"\n",
"To demonstrate that the AD1 threshold (and a related AF1 threshold, which is used to calculate the residual value at the AF1 threshold percentage) is applied, we inspect the relevant lines of `analysis_tools` [code that sets the AD1 and AF1 thresholds](https://github.com/lsst/analysis_tools/blob/2b45b7d01314f84ce12d05144fb9ae7110de62b8/python/lsst/analysis/tools/actions/keyedData/calcDistances.py#L49-L52). We see the following, indicating that the thresholds are being applied as required:\n",
"```\n",
" threshAD = Field[float](doc=\"Threshold in mas for AFx calculation.\", default=20.0)\n",
" threshAF = Field[float](\n",
" doc=\"Percentile of differences that can vary by more than threshAD.\", default=10.0\n",
" )\n",
"\n",
"```"
]
},
{
"cell_type": "markdown",
"id": "61eaafa4-c290-4b74-9628-2f967816034d",
"metadata": {},
"source": [
"## Results\n",
"We have demonstrated that there is software within the Rubin Science Pipelines to calculate `AF1`, the maximum fraction of relative astrometric measurements on 5 arcminute scales that exceed the 5 arcminute outlier limit. Additionally we have shown the metrics and plots that are produced by `analysis_tools` each time the DRP pipeline is executed. Thus the result of this test is a \"**Pass**\"."
"We have demonstrated that there is software within the Rubin Science Pipelines to calculate `AF1`, the maximum fraction of relative astrometric measurements on 5 arcminute scales that exceed the 5 arcminute outlier limit. Additionally we have shown the metrics and plots that are produced by `analysis_tools` each time the DRP pipeline is executed, and shown that the DM code is applying the proper thresholds. Thus the result of this test is a \"**Pass**\"."
]
},
{
Expand Down

0 comments on commit 8ecd7a0

Please sign in to comment.