Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests to the pytest framework. #34

Merged
merged 7 commits into from
Nov 29, 2019
Merged

Conversation

yakutovicha
Copy link
Collaborator

@yakutovicha yakutovicha commented Nov 8, 2019

fixes #28
fixes #29
fixes #31

@yakutovicha yakutovicha changed the title first try Move tests to the pytest framework. Nov 26, 2019
@yakutovicha
Copy link
Collaborator Author

@ltalirz do you have an idea why the 0907397 tests are failing?

The problem is with example_base_binary_restart.py If I run it without pytest, it goes fine, but under pytest it is hanging.

@ltalirz
Copy link
Member

ltalirz commented Nov 28, 2019

I would have to look through the code...
If you can reproduce it locally, it should be quite straightforward to figure out which part is hanging.

@yakutovicha
Copy link
Collaborator Author

I would have to look through the code...
If you can reproduce it locally, it should be quite straightforward to figure out which part is hanging.

Yes, locally I have the same problem. But I don't know what to look at to understand the origin of the strange behaviour.

Looks like the calculation wasn't submitted and top doesn't show anything strange.

What should I look at to narrow down the origin of the problem?

@yakutovicha
Copy link
Collaborator Author

I am going to merge this PR to make a release. The issue of the hanging test I will solve in a different PR.

@yakutovicha yakutovicha merged commit d5b81bb into develop Nov 29, 2019
@yakutovicha yakutovicha deleted the run_all_through_pytest branch November 29, 2019 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add coveralls, and build (travis) bandges Add coveralls Move examples to pytest framework
2 participants