Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SL diag library specification in cp2k parameters settings #99

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mpougin
Copy link
Collaborator

@mpougin mpougin commented Nov 10, 2022

never CP2K versions might run in a deadlock when using the default ELPA library for diagonalization

@mpougin
Copy link
Collaborator Author

mpougin commented Nov 10, 2022

@kjappelbaum can you help with the docs error?

@mpougin
Copy link
Collaborator Author

mpougin commented Nov 10, 2022

@kjappelbaum can you help with the docs error?

The docs problem is fixed in #100

@kjappelbaum
Copy link
Contributor

for the tests, I'd need to check manually and bisect the history. Just by looking at the logs, I have no clue.
I initially suspected that there has been an update in aiida-cp2k, but there was apparently no other bugfix version ...

@mpougin
Copy link
Collaborator Author

mpougin commented Nov 10, 2022

for the tests, I'd need to check manually and bisect the history. Just by looking at the logs, I have no clue. I initially suspected that there has been an update in aiida-cp2k, but there was apparently no other bugfix version ...

Also, it all runs locally for me

@ltalirz
Copy link
Member

ltalirz commented Nov 10, 2022

note that aiida-lsmo uses aiida-testing, i.e. it will read results from the pre-computed test database if they don't exist.

did you try updating the test database?
https://aiida-lsmo.readthedocs.io/en/latest/development.html#updating-the-test-data

@ltalirz
Copy link
Member

ltalirz commented Nov 13, 2022

Looking at the current commit history, it seems like one of the tests is flaky: #102

Here, 3 tests are failing, so two of those might be legitimate problems (edit: here you seem to be updating the inputs, so that will require an update of the test database)

In any case, I would suggest rebasing this branch on top of develop before continuing

@mpougin
Copy link
Collaborator Author

mpougin commented Nov 13, 2022

okay, thanks a lot for your input :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants