[device_id] complete DeviceID proto cleanup #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the Certificate message to the cert.proto (from the device_id.proto), since it is not directly related to a device ID. Signed-off-by: Tim Trippel <ttrippel@google.com>
The TPM and BMC device registration functions are not relevant to OpenTitan device provisioning. Signed-off-by: Tim Trippel <ttrippel@google.com>
This updates the DeviceData message to align with the reference OpenTitan provisioning flow (in lowRISC/opentitan) repo. Specifically, this makes the DeviceData simpler / more generic, by encapsulating all assets (i.e., certs, seeds, etc.) provisioned into the device into a single data payload byte array that can be up to 8k per device. This enables supporting various OpenTitan SKUs that may provision different sets of certificates and/or seeds into flash that must be harvested during FT. Signed-off-by: Tim Trippel <ttrippel@google.com>
This updates the DeviceLifeCycle enum to remove LC states that are not relevant to OpenTitan devices. The "Invalid" LC state is also removed as it does not represent a valid LC state a device may be provisioned into. Signed-off-by: Tim Trippel <ttrippel@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the DeviceID proto cleanup by:
Specifically, the latter updates the DeviceData message to simplify it / make more generic, by encapsulating all assets (i.e., certs, seeds, etc.) provisioned into the device into a single data payload byte array that can be up to 8k per device. This enables supporting various OpenTitan SKUs (and is the way the reference provisioning flow in the opentitan repo is implemented) that may provision different sets of certificates and/or seeds into flash that must be harvested during FT.
Lastly, this removes code that is not relevant to OpenTitan provisioning, namely: