-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated OpenTitan's DPI based Virtual UART into the verilator test bench #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments and suggested changes to the location and expression of the Verilator-specific top level.
Otherwise, this looks good to me, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments from my end. I still need to test this PR and will approve afterwards.
With my initial test the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, both screen output and log file are now generating properly for me, so this all looks good to me!
Thanks so much for making these changes! This is will increase the usability of the Ibex demo system drastically 👍 |
Update code from upstream repository https://github.com/lowRISC/opentitan to revision 042415198f3dc6b3bc387c669c7e9cf982d208e2 Signed-off-by: Hugo McNally <hugo.mcnally@gmail.com>
There's a bug in verilator 5.018, which means the system can't be built. Reverting to ibex's officially supported version, 4.210.
↑ Rebased ↓ Made suggested changes |
Draft because it's currently sitting atop #91
Recommend making the following change when testing: