Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ciphers attribute to SSLOptions #1582

Merged
merged 3 commits into from
Aug 24, 2024
Merged

Add ciphers attribute to SSLOptions #1582

merged 3 commits into from
Aug 24, 2024

Conversation

womblep
Copy link
Contributor

@womblep womblep commented Aug 16, 2024

Fixes issue #1581
Allows a ciphers attribute to be used to pass a cipher string in OpenSSL format to adapters
This controls which ciphers are chosen to connect to the server.

@olleolleolle olleolleolle linked an issue Aug 20, 2024 that may be closed by this pull request
Add ciphers to SSL options #1581
Closed
iMacTia
iMacTia approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@iMacTia iMacTia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in the linked issue, this is an SSL feature we CAN support in most adapters, so happy to add it to the list of options 👍
Thank you for the research work!

@iMacTia iMacTia merged commit 9056ecc into lostisland:main Aug 24, 2024
7 checks passed
@iMacTia iMacTia mentioned this pull request Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMacTia iMacTia iMacTia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ciphers to SSL options
2 participants
@womblep @iMacTia