Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a #close implementation, calling #shutdown on any cached_connection #23

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Add a #close implementation, calling #shutdown on any cached_connection #23

merged 1 commit into from
Aug 20, 2024

Conversation

olleolleolle
Copy link
Member

@olleolleolle olleolleolle commented Aug 20, 2024 •
edited
Loading

This PR adds the Faraday adapter #close implementation which calls the Net Http Persistent's shutdown method.

See docs for authoring middleware:

@olleolleolle olleolleolle marked this pull request as ready for review August 20, 2024 14:20
@olleolleolle olleolleolle changed the title WIP: add #close Add a #close implementation, calling #shutdown on any cached_connection Aug 20, 2024
@olleolleolle olleolleolle merged commit 2d35fce into main Aug 20, 2024
7 checks passed
@olleolleolle olleolleolle deleted the add-close branch August 20, 2024 14:21
@olleolleolle olleolleolle mentioned this pull request Aug 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iMacTia iMacTia iMacTia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olleolleolle @iMacTia