Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add function to get folder Id #615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Itzaprado
Copy link
Collaborator

The following changes were made to fix infinite loading when the user has a high storage on their Drive.

Changelog:
[ ] Add function to get folderID from provided folder name
[ ] Change parents value to use the obtained folderID
[ ] Change dropdown for an input text
[ ] Update tests with the expected form

@Itzaprado Itzaprado requested a review from a team as a code owner July 25, 2024 16:39
@Jonting416
Copy link
Contributor

If I understand correctly, this change will update the form to no longer be a drop down and then require the end user to input the folder ID. Then, on execute, we will validate this folder ID by searching the list of all folders to ensure that it exists, otherwise fail because we were unable to find the folder ID?

@Itzaprado
Copy link
Collaborator Author

If I understand correctly, this change will update the form to no longer be a drop down and then require the end user to input the folder ID. Then, on execute, we will validate this folder ID by searching the list of all folders to ensure that it exists, otherwise fail because we were unable to find the folder ID?

Yes, but instead of the folder ID it should be the folder name, then on execute we search for the folder ID and if it doesn't exist we use the drive root to save the file.

@jimbert
Copy link
Collaborator

jimbert commented Aug 5, 2024

How does it work if there are multiple folders of the same name?

@Itzaprado
Copy link
Collaborator Author

How does it work if there are multiple folders of the same name?

The file is saved in the first folder found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants