Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a notice prohibiting retention policies on backup targets #1010

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

derekbit
Copy link
Member

Which issue(s) this PR fixes:

Issue longhorn/longhorn#9795

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for longhornio ready!

Name Link
🔨 Latest commit f1a3d73
🔍 Latest deploy log https://app.netlify.com/sites/longhornio/deploys/67354d3d941e4b0008406e46
😎 Deploy Preview https://deploy-preview-1010--longhornio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

innobead
innobead previously approved these changes Nov 13, 2024
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LGTM. Waiting for @longhorn/doc review.

Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions for your consideration. Thanks.

Longhorn 9795

Signed-off-by: Derek Su <derek.su@suse.com>
Copy link
Contributor

@jhkrug jhkrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@innobead innobead merged commit 78f78dc into longhorn:master Nov 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants