Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: allow ssh into nodes to make debugging easier #1594

Closed
wants to merge 2 commits into from
Closed

infra: allow ssh into nodes to make debugging easier #1594

wants to merge 2 commits into from

Conversation

yangchiu
Copy link
Member

@yangchiu yangchiu commented Nov 16, 2023 •
edited
Loading

infra: allow ssh into nodes to make debugging easier

For longhorn/longhorn#6601

Signed-off-by: Yang Chiu yang.chiu@suse.com

@yangchiu yangchiu requested review from innobead and a team November 16, 2023 08:25
@yangchiu yangchiu self-assigned this Nov 16, 2023
@yangchiu yangchiu changed the title infra: assign public ip and allow ssh to worker nodes to make debugging easier infra: assign public ip to worker nodes and output kubeconfig to make debugging easier Nov 30, 2023
innobead
innobead requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest making exporting worker nodes public optional, so this could make us have more flexibilty for testing env setup.

pipelines/utilities/kubeconfig.sh Outdated Show resolved Hide resolved
@yangchiu
Copy link
Member Author

Suggest making exporting worker nodes public optional, so this could make us have more flexibilty for testing env setup.

I'll add this option.

@yangchiu yangchiu force-pushed the e2e-debugging branch 5 times, most recently from 2324691 to 22769c0 Compare December 21, 2023 09:26
@yangchiu
Copy link
Member Author

Suggest making exporting worker nodes public optional, so this could make us have more flexibilty for testing env setup.

I'll add this option.

Switching between public ip and private network is more complicated than expected. Simply disabled associate_public_ip_address won't work. Need more time to investigate.

@yangchiu yangchiu marked this pull request as draft December 21, 2023 10:48
@yangchiu yangchiu force-pushed the e2e-debugging branch 2 times, most recently from 6e60fad to 5b4fa28 Compare December 22, 2023 03:25
@yangchiu yangchiu marked this pull request as ready for review December 25, 2023 01:35
@yangchiu
Copy link
Member Author

Switching between public ip and private network is more complicated than expected. Simply disabled associate_public_ip_address won't work. Need more time to investigate.

Refined. If it has a public ip, it can directly communicate with Internet. If it doesn't have a public ip, use nat to communicate with Internet.

@yangchiu
Copy link
Member Author

Suggest making exporting worker nodes public optional, so this could make us have more flexibilty for testing env setup.

Added option in longhorn/infra#153.

@yangchiu
infra: assign public ip to nodes to make debugging easier
af84fc3 
Signed-off-by: Yang Chiu <yang.chiu@suse.com>
@yangchiu yangchiu changed the title infra: assign public ip to worker nodes and output kubeconfig to make debugging easier infra: allow ssh into nodes to make debugging easier Feb 6, 2024
innobead
innobead requested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@innobead innobead left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing the private network for worker nodes, have you considered bastion way to ssh from local to the internal nodes?

Suggest this way to avoid exposing instance access for security reasons.
https://repost.aws/knowledge-center/ec2-troubleshoot-bastion-host-connection

@yangchiu yangchiu mentioned this pull request Feb 26, 2024
Closed
@yangchiu
Copy link
Member Author

More investigation needed. Close this for now.

@yangchiu yangchiu closed this Feb 26, 2024
@innobead
Copy link
Member

Sounds good @yangchiu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innobead innobead innobead requested changes

Assignees

@yangchiu yangchiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yangchiu @innobead