Additinoal labels for all resources (v1.7.x) #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Levent Yalcin <leventyalcin@gmail.com>
leventyalcin
force-pushed
the
additional-labels-1.7.x
branch
from
8df38d5
to
bd0c36d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here and there, some installations forces to use predefined labels. This helps to use additional labels.
I believe this PR is incomplete without updating the README. However, I couldn't figure out how to do that.
Also, I couldn't figure out how to tell those labels to longhorn-manager. Therefore, things like csi-attacher etc would also use the those labels. Any guidance appreciated.