Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added method to fetch project versions using GitHub API, removed hardcoded versions in tests #526

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Onager
Copy link
Contributor

@Onager Onager commented Dec 18, 2018

Testing Travis at the moment, no need for review.

@codecov
Copy link

codecov bot commented Apr 13, 2019

Codecov Report

Merging #526 into master will increase coverage by 0.15%.
The diff coverage is 47.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
+ Coverage   28.24%   28.39%   +0.15%     
==========================================
  Files          48       48              
  Lines        4752     4790      +38     
==========================================
+ Hits         1342     1360      +18     
- Misses       3410     3430      +20
Impacted Files Coverage Δ
l2tdevtools/download_helpers/interface.py 57.57% <5.88%> (-17.94%) ⬇️
l2tdevtools/download_helpers/github.py 68.22% <80.95%> (+3.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42de785...1927d76. Read the comment docs.

@joachimmetz joachimmetz added the blocked Work cannot progress until another issue is resolved label May 21, 2019
@joachimmetz
Copy link
Member

@Onager I think 524c91f introduces similar behavior as you intended for this PR? Close this PR?

@joachimmetz joachimmetz changed the base branch from master to main February 8, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Work cannot progress until another issue is resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants