Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parts redux #58

Merged
merged 6 commits into from
Apr 4, 2024
Merged

Parts redux #58

merged 6 commits into from
Apr 4, 2024

Conversation

Rinn
Copy link
Member

@Rinn Rinn commented Apr 4, 2024

  • Change parts to confirm mafia data, confirmation false now means a part is listed for a monster but appears incorrect, true is if a part isn't listed
  • Don't parse when text altering effects are active
  • Text altering effects however are fine if a source uses skill ids instead of text parsing
  • Add yarn lint

@gausie gausie merged commit 2ed7066 into main Apr 4, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
@gausie
Build: (2ed7066) Parts redux (#58)
10b8ef3 
* add yarn lint, update kolmafia package

* add helper isAdventureTextAltered

* update monster parts to confirm mafia data

* don't check round here

* don't bother caching

* unused
@gausie gausie deleted the parts-redux branch April 4, 2024 08:17
midgleyc
midgleyc reviewed Apr 4, 2024
View reviewed changes
packages/excavator-script/src/utils/game.ts
import { $effects, $items, $locations, have } from "libram";

const ALTERING_EFFECTS = $effects`Can Has Cyborger, Dis Abled, Haiku State of Mind, Just the Best Anapests, O Hai!, Robocamo, Temporary Blindness`;
const ALTERING_EQUIPMENT = $items`makeshift turban, staph of homophones, sword behind inappropriate prepositions`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also papier-mâchine gun and papier-mâchéte, I think

midgleyc
midgleyc reviewed Apr 4, 2024
View reviewed changes
packages/excavator-script/src/projects/monsterParts.ts
})),
);

data.push(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a bug in the original too, but if you have the perk for detecting butts, excavator shouldn't send data for butts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midgleyc midgleyc midgleyc left review comments

@gausie gausie gausie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rinn @gausie @midgleyc