Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bug claim aud is not a string #9

Merged
merged 5 commits into from
Mar 18, 2024
Merged

Conversation

lmammino
Copy link
Owner

@lmammino lmammino commented Mar 16, 2024

Fixes #8

@markdespain, @lorenzobrusco Would you be able to do a quick review of this one?

TODO

  • Increase test coverage
  • Update docs

@lmammino lmammino linked an issue Mar 16, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.46%. Comparing base (d3da62d) to head (c316a3e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   89.90%   90.46%   +0.56%     
==========================================
  Files           9        9              
  Lines         911      965      +54     
==========================================
+ Hits          819      873      +54     
  Misses         92       92              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markdespain
Copy link
Contributor

looks good!

@lmammino
Copy link
Owner Author

Thanks @markdespain ! I'll increase the test coverage and update the docs and get this published :)

@lmammino lmammino marked this pull request as ready for review March 18, 2024 11:03
@lmammino lmammino merged commit 09459db into main Mar 18, 2024
4 checks passed
@lmammino lmammino deleted the 8-bug-claim-aud-is-not-a-string branch March 18, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Claim 'aud' is not a string
2 participants