Add User-Agent header to reqwest client for JWKS request #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmammino
reviewed
Jul 29, 2024
lmammino
approved these changes
Jul 29, 2024
|
Awesome! Thanks for the amazing contribution! What do you think about adding the current version with a dynamic reference? Could you please test if this works for you? Happy to get this merged and released ASAP then! |
|
Confirmed the changes work as expected in the AWS WAF environment. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 94.09% 94.11% +0.01%
==========================================
Files 9 9
Lines 1186 1189 +3
==========================================
+ Hits 1116 1119 +3
Misses 70 70 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider adding a User-Agent header to the reqwest client. Otherwise, the request is blocked by the NoUserAgent_HEADER rule of the AWSManagedRulesCommonRuleSet in AWS WAF.