fix(useAnimations): flag to enable sleep wake scenarios #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #{issue-number}
Description
The sleep/wake scenario in this hook, which was previously added as the fix for top bar alerts scenarios, caused incorrect state change for other components that don't use a controlled state when the user lefts the browser tab. This change adds a conditional flag to enable this feature and is currently used for the top bar notifications components only.
Also added the dedicated hook for that, as it could be improved in the future and brings more code consistency in the hooks.
Storybook
https://feature-use-animations-fix--613a8e945a5665003a05113b.chromatic.com
Checklist
Obligatory: