Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ProductSwitcher): update Text Accounts name and icon #1423

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

robertp-lc
Copy link
Contributor

@robertp-lc robertp-lc commented Nov 6, 2024

Resolves: #1415

Description

  • updated name for Text Accounts and changed icon

Note: I used existing icon in DS instead of new assets available on cdn server. I initially wanted to but it would require converting svg from url to react component which will be done anyway in the future when wrapper component for those assets will be introduced in DS. Hope it will be good enough for the time being.

Storybook

https://feature-1415--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add correct label
  • Assign pull request with the correct issue

@robertp-lc robertp-lc added the High-prio High priority task label Nov 6, 2024
@robertp-lc robertp-lc requested a review from a team November 6, 2024 10:45
@robertp-lc robertp-lc self-assigned this Nov 6, 2024
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@VadymBezpalko VadymBezpalko merged commit 76d5635 into main Nov 7, 2024
5 checks passed
@VadymBezpalko VadymBezpalko deleted the feature/1415 branch November 7, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High-prio High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ProductSwitcher] - Updates
3 participants