Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweak(Tooltip): better docs; marking closeWithX as deprecated #1412

Merged
merged 7 commits into from
Oct 21, 2024
Merged

tweak(Tooltip): better docs; marking closeWithX as deprecated #1412

merged 7 commits into from
Oct 21, 2024

Conversation

VadymBezpalko
Copy link
Contributor

@VadymBezpalko VadymBezpalko commented Oct 18, 2024 •
edited by github-actions bot
Loading

Resolves: #817

Description

  • Marking closeWithX as deprecated prop. Using handleCloseAction should be enough to show the close button.
  • Preparing better docs with examples for Tooltip subcomponents and their use cases.

Storybook

https://feature-817--613a8e945a5665003a05113b.chromatic.com

Checklist

Obligatory:

  • Self review (use this as your final check for proposed changes before requesting the review)
  • Add correct label
  • Assign pull request with the correct issue

@VadymBezpalko VadymBezpalko self-assigned this Oct 18, 2024
@VadymBezpalko VadymBezpalko linked an issue Oct 21, 2024 that may be closed by this pull request
[Tooltip] - Make docs with more examples #816
Closed
vladko-uxds
vladko-uxds approved these changes Oct 21, 2024
View reviewed changes
Copy link

@vladko-uxds vladko-uxds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@VadymBezpalko VadymBezpalko merged commit 5597095 into main Oct 21, 2024
5 checks passed
@VadymBezpalko VadymBezpalko deleted the feature/817 branch October 21, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladko-uxds vladko-uxds vladko-uxds approved these changes

@marcinsawicki marcinsawicki marcinsawicki approved these changes

Assignees

@VadymBezpalko VadymBezpalko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tooltip] - Interactive tooltip types [Tooltip] - Make docs with more examples
3 participants
@VadymBezpalko @marcinsawicki @vladko-uxds