Fix clippy #7564
ci.yml
on: push
VimScript
15s
Rustfmt
23s
Clippy
2m 9s
Rust Tests
2m 17s
Rust Build
5m 10s
Docs Test
1m 49s
Python Dynamic Module
1m 6s
Annotations
6 errors and 26 warnings
field `container_name` is never read:
crates/maple_core/src/stdio_server/provider/impls/lsp.rs#L199
error: field `container_name` is never read
--> crates/maple_core/src/stdio_server/provider/impls/lsp.rs:199:9
|
194 | pub struct WorkspaceItem {
| ------------- field in this struct
...
199 | pub container_name: Option<String>,
| ^^^^^^^^^^^^^^
|
= note: `WorkspaceItem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|
field `container_name` is never read:
crates/maple_core/src/stdio_server/provider/impls/lsp.rs#L150
error: field `container_name` is never read
--> crates/maple_core/src/stdio_server/provider/impls/lsp.rs:150:9
|
146 | pub struct DocumentItem {
| ------------ field in this struct
...
150 | pub container_name: Option<String>,
| ^^^^^^^^^^^^^^
|
= note: `DocumentItem` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
|
fields `start` and `input` are never read:
crates/maple_core/src/stdio_server/provider/mod.rs#L126
error: fields `start` and `input` are never read
--> crates/maple_core/src/stdio_server/provider/mod.rs:126:9
|
122 | pub struct ProviderEnvironment {
| ------------------- fields in this struct
...
126 | pub start: BufnrWinid,
| ^^^^^
127 | pub input: BufnrWinid,
| ^^^^^
|
= note: `ProviderEnvironment` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
|
this `if` statement can be collapsed:
crates/maple_core/src/stdio_server/plugin/git.rs#L255
error: this `if` statement can be collapsed
--> crates/maple_core/src/stdio_server/plugin/git.rs:255:17
|
255 | / if filepath.canonicalize()?.starts_with(&git.repo) {
256 | | if git.is_tracked(filepath).unwrap_or(false) {
257 | | self.vim
258 | | .exec("clap#plugin#git#set_branch_var", (bufnr, branch.trim()))?;
259 | | }
260 | | }
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
= note: `-D clippy::collapsible-if` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]`
help: collapse nested if block
|
255 ~ if filepath.canonicalize()?.starts_with(&git.repo) && git.is_tracked(filepath).unwrap_or(false) {
256 + self.vim
257 + .exec("clap#plugin#git#set_branch_var", (bufnr, branch.trim()))?;
258 + }
|
|
field `browser_download_url` is never read:
crates/upgrade/src/github.rs#L11
error: field `browser_download_url` is never read
--> crates/upgrade/src/github.rs:11:9
|
8 | pub struct Asset {
| ----- field in this struct
...
11 | pub browser_download_url: String,
| ^^^^^^^^^^^^^^^^^^^^
|
= note: `Asset` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis
= note: `-D dead-code` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(dead_code)]`
|
Clippy
Clippy had exited with the 101 exit code
|
VimScript
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
VimScript
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Python Dynamic Module
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Python Dynamic Module
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Docs Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Docs Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Docs Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Docs Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Docs Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Docs Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Clippy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Clippy
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
Rust Tests
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust Tests
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
Rust Build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
Rust Build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|