feat: adding error handling to spans (Distributed Tracing) #728
+80
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaeyeon Park <donionbs7@gmail.com>
moggaa
changed the title
moggaa
changed the title
moggaa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR enhances the distributed tracing instrumentation by adding error handling to spans
It is a follow-up to PR #706 and implements phase 4 of issue #709.
This PR implements pod delete experiment only. (That’s why I marked the PR as a draft.)
This screenshot shows the result of the experiment on failure, with the error tag set to true and the exception event visible.
Special notes for your reviewer:
Checklist:
breaking-changestagrequires-upgradetag