-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cache store route parameter #3871
Open
dylandoamaral
wants to merge
26
commits into
litestar-org:v3.0
Choose a base branch
from
dylandoamaral:feat/add-cache-store-route-parameter
base: v3.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add cache store route parameter #3871
dylandoamaral
wants to merge
26
commits into
litestar-org:v3.0
from
dylandoamaral:feat/add-cache-store-route-parameter
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Trigger documentation build * Trigger documentation build * docs: update to v3 style * docs: move some things to litestar.dev repo, change versioning, add environment tag * docs: update landing page * chore: update lockfile * chore: add AA upper constraint * fix(docs): re-colonize * docs: enable sphinx-togglebutton * docs: use current year var * deps: update deps * fix(docs): do not link __name__ for now * fix(docs): use correct link to page --------- Co-authored-by: Peter Schutt <peter.github@proton.me>
* Remove deprecated StaticFiles and StaticFilesConfig * remove special casing of static files app from handlers/router * remove outdated docs sections * Add what's new section * Rename tests for consistency
This PR changes behavior of parameters that are typed in a union with `None`. Prior behavior was to implicitly default their value to `None` if a value wasn't provided making an apparently non-optional parameter (i.e., no declared default) actually optional. Surprising behavior at best, dangerous at worst. New behavior is to throw a client error when a parameter without a default is not provided.
* refactor: removes deprecated OpenAPIController This PR removes all deprecated elements of OpenAPIConfig and the OpenAPIController, removes any obsolete tests and refactors tests that were parametrized to test both OpenAPIController and the router-based approach. * docs: What's new entry * Update docs/usage/openapi/ui_plugins.rst Co-authored-by: Jacob Coffee <jacob@z7x.org> * Update litestar/openapi/config.py * fix: remove whitespace * fix: import table formatting (i hope) --------- Co-authored-by: Jacob Coffee <jacob@z7x.org>
…e` (litestar-org#3393) * Remove 'app' parameter from `.to_asgi_response`
Remove the deprecated utility functions, `get_litestar_scope_state``, ``set_litestar_scope_state``, ``delete_litestar_scope_state``, and ``is_sync_or_async_generator``.
…3386) * remove handler names * Remove option handler creation from HTTPRoute * Remove methods attribute from BaseRoute * Move kwargs model to handlers and creation to on_registration * Store kwargs model on handlers instead of routes * Simplify HTTPRoute route_handler_map creation * Simplify Router.route_handler_method_map * Relax typing of HTTPRoute * Move handling logic to route handlers * Remove scope_type * Don't pass route to HTTPRouteHandler during handling * Don't pass scope to handle methods * Resolve and establish connections in routes; Only pass connections to handlers --------- Co-authored-by: Jacob Coffee <jacob@z7x.org> Co-authored-by: Peter Schutt <peter.github@proton.me>
fix(docs): adjust build script
* Backport static files path traversal fix
* make route handlers functional decorators
…ors (litestar-org#3529) Remove deprecated test
ignore type error
…deprecated params of internal `ExceptionHandlerMiddleware` (litestar-org#3435) * refactor!: Remove deprecated `app` param of `Response.to_asgi_response` (litestar-org#3393) * Remove 'app' parameter from `.to_asgi_response` * Remove debug param * Remove exception_handlers param * Remove litestar.middleware.exceptions
Port parse_values_from_connection_kwargs changes
github-actions
bot
added
the
area/middleware
This PR involves changes to the middleware
label
Nov 22, 2024
github-actions
bot
added
size: small
type/feat
pr/external
Triage Required 🏥
This requires triage
labels
Nov 22, 2024
provinzkraut
requested review from
JacobCoffee and
provinzkraut
as code owners
November 24, 2024 11:35
provinzkraut
force-pushed
the
v3.0
branch
3 times, most recently
from
November 29, 2024 15:24
c56cc1c
to
670a5cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/middleware
This PR involves changes to the middleware
pr/external
size: small
Triage Required 🏥
This requires triage
type/feat
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the user to define on a route level basis what would be the used namespace by overriding the default one. It allows, as an example, to delete some routes easily solely based on the namespace.
This is my first commit in this repository, I don't know if I did it right. Sorry for the inconvenience ! By the way, after reading the documentation for contributing, I don't know when and if I have to run the all-contributors myself.
Closes #3869.
Closes
Closes #3854