Allow Fetcher to dynamically change where artifacts are retrieved from based on the scheme from the Registry. #31
+1,115
−122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m based on the scheme from the Registry.
Merged
linyows
reviewed
Oct 7, 2023
repo/github_release.go
Outdated
| _ registory.Registory = (*GithubRelease)(nil) | ||
| _ storage.Fetcher = (*GithubRelease)(nil) | ||
| ) | ||
| var _ registory.Registory = (*GithubRelease)(nil) |
There was a problem hiding this comment.
What do you mean this line for syntax?
There was a problem hiding this comment.
To ensure at compile time that GithubRelease satisfies the registry.Registry.
On another note, I'm typoing...
There was a problem hiding this comment.
I see, it's a type assertion to an interface.
k1LoW
force-pushed
the
create-fectcher-github-release
branch
from
d11b3cf
to
202c7c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I would like you to review #30 first.)
ref: #16
Allow Fetcher to dynamically change where artifacts are retrieved from based on the scheme from the Registry.
Currently not available as there is only one registry, but
s3://andgcs://are also supported as examples.