Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nemo-desktop: use app_id as .desktop file name #3340

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

sertonix
Copy link
Contributor

@sertonix sertonix commented Dec 28, 2023

This is suggested in the xdg-shell spec and makes finding the .desktop file from an application easier.

@mtwebster mtwebster merged commit 4aa7a7b into linuxmint:master Mar 7, 2024
2 checks passed
clefebvre added a commit that referenced this pull request Apr 12, 2024
This reverts commit 4aa7a7b.

The easiest way to find the desktop file for Nemo is to call it
nemo.desktop.

Not any of the following:

org.Nemo
com.Nemo
io.Nemo
com.cinnamon.Nemo
com.linuxmint.cinnamon.Nemo

This creates regressions since it breaks any ref to the app (namely
people adding it as a pin in GWL) and it serves no purpose nor fixes
any bugs we're aware of.
@clefebvre
Copy link
Member

This was reverted. We don't have a DNS for this project, let alone a reverse DNS. org.Nemo is completely random and harder to find than the appname.

@sertonix sertonix deleted the patch-1 branch April 21, 2024 18:37
@sertonix
Copy link
Contributor Author

I wanted to make sure that the desktop file name matches the app_id but I see that you changed the app_id accordingly so I am fine with that revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants