network applet: fixes to # of visible networks #12417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In _createSection() and _createNetworkItem(), previously we would skip the menu index in which the active network is present. If this index was < NUM_VISIBLE_NETWORKS, then we could display too few networks before we begin stashing them in the "more" menu. _accessPointAdded() is also refactored to more closely resemble the above two, but this is a nonbehavioral change.
When adding a network, if we add it to a menu index < NUM_VISIBLE_NETWORKS, if we now have > NUM_VISIBLE_NETWORKS networks, we need to push the last visible network to being the first network in the "more" menu. Otherwise, we could end up with too many visible networks. When updating a network position, we first removed it from the menu. When doing this, if its original menu index was < NUM_VISIBLE_NETWORKS, then we need to bump the first network in the "more" menu to being the last visible network. We now do this by now calling the already existing _accessPointRemoved() method which handles this case. Otherwise, we could end up with too few visible networks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are more than
NUM_VISIBLE_NETWORKStotal networks, there should be exactlyNUM_VISIBLE_NETWORKSvisible networks. This pull request contains two commits aimed at fixing different scenarios in which there are more thanNUM_VISIBLE_NETWORKStotal networks but where the number of actually visible networks may be more thanNUM_VISIBLE_NETWORKSor fewer thanNUM_VISIBLE_NETWORKS. I was especially motivated to make these fixes because, on lower resolution displays, if many more networks thanNUM_VISIBLE_NETWORKSare displayed, the menu may exceed the size of the screen and some networks may not be easily selectable.