Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write readme and refactor some code #493

Merged
merged 7 commits into from
Aug 18, 2023
Merged

Write readme and refactor some code #493

merged 7 commits into from
Aug 18, 2023

Conversation

Cheny-chui
Copy link
Contributor

重构代码

  • 将bpf.c中重复代码提取为以下宏
    • CONN_INIT
    • CONNN_ADD_ADDRESS
    • CONN_ADD_EXTRA_INFO
    • PACKET_INIT_WITH_COMMON_INFO

添加参数

  • 添加以下参数：
    • a：是否保留已Close的连接信息
    • d：约束连接的目的端口
    • s：约束连接的源端口

README

  • 编写README以帮助部署

helight
helight reviewed Aug 11, 2023
View reviewed changes
eBPF_Supermarket/Network_Subsystem/tcp_watch/README.md
- [x] 根据相关工具代码，设计并实现各个TCP连接发送与接收包信息的记录
- [ ] 更具相关工具代码，设计并实现TCP错误包信息的记录
- [ ] 调查相关资料，实现从TCP包中抽取HTTP信息并记录
- [ ] 讨论与Prometheus的连接方案并实现
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个还是要保留呀，这个其实很重要

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以分为：

  1. 已经具备能力
  2. todo 能力

helight
helight approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@helight helight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helight helight merged commit aa4f1f9 into linuxkerneltravel:develop Aug 18, 2023
2 checks passed
@Cheny-chui Cheny-chui mentioned this pull request Aug 18, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helight helight helight approved these changes

@LinkinPF LinkinPF Awaiting requested review from LinkinPF LinkinPF is a code owner

@chenamy2017 chenamy2017 Awaiting requested review from chenamy2017 chenamy2017 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cheny-chui @helight