Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] 添加基于ebpf观测用户态函数时延项目 #480

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

jyf111
Copy link
Contributor

@jyf111 jyf111 commented Jul 28, 2023

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

添加一个新项目

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Copy link
Member

@helight helight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// Copyright 2023 The LMP Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://github.com/linuxkerneltravel/lmp/blob/develop/LICENSE
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
//
// author: xxx@xxx.xxx
//
// 文件功能说明,说明该文件的用途和目的


以上是我们的代码注释头,大家顺手都加上

@helight
Copy link
Member

helight commented Jul 28, 2023

另外整体代码的注释比较少,适当增加一下注释

@chenamy2017
Copy link
Contributor

增加一个README文件,对项目进行说明,后续提交持续更新完善此文件。

@jyf111
Copy link
Contributor Author

jyf111 commented Aug 3, 2023

我添加了License,基于doxygen添加了更多的注释和文档,并加入了README文件。

@jyf111 jyf111 requested a review from helight August 3, 2023 05:02
Copy link
Member

@helight helight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.keep 这个文件不用提交

@jyf111 jyf111 requested a review from helight August 3, 2023 06:57
@LinkinPF
Copy link
Member

LinkinPF commented Aug 3, 2023

以后注意小步提交,这个pr提交的代码量太大了

Copy link
Member

@helight helight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@helight helight merged commit 4d9b371 into linuxkerneltravel:develop Aug 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants