handle nils correctly in ParamExpander #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaionaro
previously approved these changes
May 9, 2024
mimir-d
force-pushed
the
bugfix/handle_nil_in_paramexpander
branch
from
87f3af4
to
7891bf0
Compare
- previously, for types that can be nil (specifically slice, map;
interface and pointer are correct), a new value of backing type
was created instead of making a new nil
- this is incorrect because it affects the structure of the object; more
specifically the failure observed was with a struct having a field of
type `[]string`. Instead of keeping a `[]string(nil)` here, this would
transform into an empty slice `[]string{}`
Signed-off-by: mimir-d <mimir-d@users.noreply.github.com>
mimir-d
force-pushed
the
bugfix/handle_nil_in_paramexpander
branch
from
7891bf0
to
d494b08
Compare
|
this was previously approved; im merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[]string. Instead of keeping a[]string(nil)here, this would transform into an empty slice[]string{}