J1939 vehicle position #553
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce `libj1939_connect_socket` function to handle socket connections. Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
Introduce `timespec_earliest` to determine the earlier of two given `timespec` values. This function compares the seconds and nanoseconds fields of the provided `timespec` structures and returns the earlier one. Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
…ition Server This patch adds `j1939-vehicle-position-srv`, a server for sending vehicle position data over CAN using J1939 or NMEA 2000 protocols. It retrieves GPS data from gpsd or simulates data if gpsd is unavailable. By default, it operates in J1939 profile but can switch to NMEA 2000 with the `-p nmea2000` option. Usage Examples: 1. With gpsd: j1939acd -r 64-95 -c /tmp/1122334455667789.jacd 1122334455667789 vcan0 & j1939-vehicle-position-srv -i vcan0 -n 0x1122334455667789 2. In simulation mode without gpsd: j1939-vehicle-position-srv -i vcan0 -s -p nmea2000 Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
olerem
requested review from
marckleinebudde and
hartkopp
and removed request for
marckleinebudde
|
To make it compile libgps-dev package is required. |
JamesB192
reviewed
Aug 4, 2024
There was a problem hiding this comment.
I would have named it timespec_earlier, eh nits.
JamesB192
reviewed
Aug 4, 2024
marckleinebudde
requested changes
Aug 5, 2024
| uint8_t sid; /* Sequence identifier */ | ||
| uint8_t source : 4, | ||
| reserved : 4; | ||
| __le16 date; /* Date in days since January 1, 1970 */ |
There was a problem hiding this comment.
Bitfields are not Endianness safe
| vp2p->total_satellites = priv->gps_data.satellites_visible; | ||
|
|
||
| if (priv->gps_data.set & DOP_SET) { | ||
| vp2p->hdop = (uint8_t)(priv->gps_data.dop.hdop * 10); |
| nmea2000_sys_time_prepare_data(struct j1939_vp_srv_priv *priv, void *data) | ||
| { | ||
| struct nmea2000_sys_time_packet *stp = | ||
| (struct nmea2000_sys_time_packet *)data; |
| struct tm tm; | ||
|
|
||
| // Get the current time | ||
| clock_gettime(CLOCK_REALTIME, &ts); |
We need a cmake option for this. |
|
https://github.com/marckleinebudde/can-utils/actions/runs/10246077261/job/28342432051#step:4:125 I think there's a header file missing. |
|
Have a look at https://github.com/marckleinebudde/can-utils/tree/j1939_vehicle_position for a WIP github actions fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set provide support for the GPSD to J1939 service. I managed to make CmakeList work so far, but i still need help to make Makefile work properly too. How to manage properly gpsd dependecy, currenty i do not know.