Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a feature that allows piet to be used in no_std environments #557

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

notgull
Copy link
Contributor

@notgull notgull commented Mar 31, 2023

As below, so above.

The main hiccup here is that I can't use Box<dyn std::error::Error> on no_std, so I just make it so the BackendError variant of Error isn't there on no_std. There is probably a more elegant solution to this problem.

@xStrom
Copy link
Member

xStrom commented Apr 1, 2023

I haven't looked at the changes in any depth, but the CI failures should be resolved.

@notgull
Copy link
Contributor Author

notgull commented May 6, 2023

I can't replicate the failures locally

@xStrom
Copy link
Member

xStrom commented Jul 24, 2023

Is this still something you would like to see merged?

If so, then the current problem is that the CI seems to be stuck in 'waiting'. I think the best approach here is for you to rebase on master and force push to your branch to re-trigger the CI for this PR. Thanks!

@notgull
Copy link
Contributor Author

notgull commented Jul 24, 2023

I still want this, it's just that I've been busy with more pressing issues.

Signed-off-by: John Nunley <dev@notgull.net>
@notgull
Copy link
Contributor Author

notgull commented Nov 18, 2023

I have no idea why the piet-core-graphics implementation is failing

@ratmice
Copy link
Contributor

ratmice commented Dec 8, 2023

@notgull #562 has a fix for the piet-coregraphics failures, but also bumps some dependencies.

I got that other failure once about local connections, but another time it went green so I'm not sure if that check is spurious or why exactly it finally went green for me.

@xStrom
Copy link
Member

xStrom commented Oct 21, 2024

Alright, some significant time has passed now. The macOS dependencies have been updated and we have a new ARM based macOS runner for CI. The master branch is passing CI nicely right now.

It would be nice to get this landed. Please rebase on master and let's see if we can get the CI to pass for this PR. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants