Improved subLayers compositionarc #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! PR seems OK! Could you please add test files under |
|
@syoyo yep, sorry for the late, i will do it asap, thanks! |
|
@syoyo done. I have noticed that the composition directory is not managed in tests. I am going to open a discussion for it. Thanks |
|
Thanks! Merged! There is a Windows ARM32 build issue, but this is an issue of CI build env. We can ignore it for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch attempts to fix the issue reported here: #207
It adds a new function CombinePrimSpecRec that is used instead of OverridePrimSpec. This is required as sublayers composition assumes a different logic (it is not a true override, as only missing properties and children are applied).
In addition to this recursiveness is now supported.