Toast and modal improvements #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixes for modals with more than one step needed
Connoropolous
commented
Oct 30, 2023
| @@ -61,9 +62,13 @@ function PreferenceSelect({ | |||
| // @ts-ignore | |||
| <Icon name={iconName} size="very-small" className="not-hoverable" /> | |||
| )} */} | |||
There was a problem hiding this comment.
can this ^^ be removed?
web/src/components/ProjectSettingsModal/ProjectSettingsModal.component.tsx
Outdated
Show resolved
Hide resolved
Connoropolous
commented
Oct 30, 2023
Connoropolous
commented
Oct 30, 2023
Connoropolous
commented
Oct 30, 2023
…o toast-and-modals
+ fix the pending button icon
to be fixed: - after checking the checkbox, hitting enter should finish creating the outcome - also if the mouse is clicked too close to the edge of the screen for opening the create outcome card, the card should be contained within the edges of the screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #333
closes #307