Switch to legacy tests setup to be able to mock requests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`datetime.UTC` is only available from Python 3.11
dbunskoek
approved these changes
Sep 13, 2023
dbunskoek
reviewed
Sep 13, 2023
| @@ -34,7 +35,7 @@ ignore = [ | |||
| ] | |||
| select = ["ALL"] | |||
| src = ["tap_linear"] | |||
| target-version = "py311" | |||
| target-version = "py38" | |||
There was a problem hiding this comment.
Because ruff will otherwise propose code improvements that are not compatible with older yet supported Python versions. Notably https://github.com/leukeleu/tap-linear/pull/1/files/3bc74435bb0edf42e6c9193cb2c5634553808231#diff-938de46e643ab091cff6a7c23e4e752e8907e2266f47889d988923352f7a1058L10 was ruff's idea, but it broke on Python < 3.11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary workaround until we figure out how to mock the API with the class-based built-in tap tests.