Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release instructions #43

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Add release instructions #43

merged 1 commit into from
Dec 7, 2023

Conversation

jaap3
Copy link
Member

@jaap3 jaap3 commented Dec 7, 2023

tagging @wadevries because I think he created this workflow

karlaevelize
karlaevelize previously approved these changes Dec 7, 2023
Copy link
Contributor

@karlaevelize karlaevelize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jaap3
Copy link
Member Author

jaap3 commented Dec 7, 2023

Just noticed we have a more detailed set of instructions in the eslint config package:

https://github.com/leukeleu/eslint-config/blob/main/CONTRIBUTORS.md

Should we just copy those?

(the prettier config package has them as well: https://github.com/leukeleu/prettier-config/blob/main/CONTRIBUTORS.md))

@karlaevelize
Copy link
Contributor

Just noticed we have a more detailed set of instructions in the eslint config package:

https://github.com/leukeleu/eslint-config/blob/main/CONTRIBUTORS.md

Should we just copy those?

(the prettier config package has them as well: https://github.com/leukeleu/prettier-config/blob/main/CONTRIBUTORS.md))

Indeed, this one is more complete and it seems to be the standard. Maybe just add it and point to it on the main README?

Copy link
Member

@wadevries wadevries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Can't remember being the one that created this release process though 😄

@jaap3 jaap3 merged commit b55cb87 into main Dec 7, 2023
1 check passed
@jaap3 jaap3 deleted the release-instructions branch December 7, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants