Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MQTT] Controller improvements #4770

Open
wants to merge 46 commits into
base: mega
Choose a base branch
from

Conversation

tonhuisman
Copy link
Contributor

@tonhuisman tonhuisman commented Aug 18, 2023

Resolves #2341
Resolves #4864
Resolves #2560

Affected controllers:

  • [C002] Domoticz MQTT
  • [C005] Home Assistant (openHAB) MQTT
  • [C006] PiDome MQTT
  • [C014] Homie MQTT convention (V3/V4)
  • [C007] Emoncms

Features:

  • MQTT Controllers: generic support for /cmd and /set topics where applicable
  • String/resource usage reductions (most of that in Homie controller)
  • Added generic CPlugin_helper_mqtt module with MQTT support functions
  • [C004] Small code improvements, add documentation and examples
  • [C007] Add configurable url, stored in Controller Publish setting, default value used when not set.

TODO:

  • Testing
  • Implement P086 (Homie receiver) support for any MQTT plugin
  • Implement event handling of C005 Home Assistant (openHAB) MQTT in other MQTT controllers
  • Fix C014 Homie MQTT convention to use proper %sysname% value
  • Update documentation

@uzi18
Copy link
Contributor

uzi18 commented Aug 19, 2023

@tonhuisman inputswitchstate is depracted, #3544

@tonhuisman
Copy link
Contributor Author

@uzi18 This was the last place in code where inputswitchstate still existed (according to VSCode search feature 😉), so should be safe to remove.

src/_C014.cpp Outdated Show resolved Hide resolved
src/_C004.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants