Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issue:4211) parse entities in comma list #4214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

puckowski
Copy link
Contributor

correctly parse all entities in a comma separated list such that all URLs are rewritten correctly

Resolves: #4211

Given:

root
├─index.html
├─asset
|   ├─rabbit
|   |    ├─hello.jpg
├─style
|   ├─rabbit
|   |    ├─index.less
|   |    ├─styles.less     

where index.less imports styles.less and styles.less has the following:

#root {
  --bg-compose: url('../../asset/rabbit/hello.jpg') no-repeat top center 100% 68px,
    url('../../asset/rabbit/hello.jpg') no-repeat 0px 67px 100% calc(100% - 67px - 67px),
    url('../../asset/rabbit/hello.jpg') no-repeat bottom center 100% 68px;
}

and index.html includes index.less and is served using ws, the output is:

#root {
  --bg-compose: url('http://192.168.0.17:8000/asset/rabbit/hello.jpg') no-repeat top center 100% 68px, url('http://192.168.0.17:8000/asset/rabbit/hello.jpg') no-repeat 0px 67px 100% calc(100% - 67px - 67px), url('http://192.168.0.17:8000/asset/rabbit/hello.jpg') no-repeat bottom center 100% 68px;
}

I ran all tests locally and they pass.

What:

Not all entities are parsed correctly in a comma separated list and may result in incorrect CSS output.

Why:

Users expect correct CSS output when using comma separated lists with valid CSS syntax.

Checklist:

  • Documentation
  • Added/updated unit tests
  • Code complete

correctly parse all entities in a comma separated list such that all
URLs are rewritten correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The urls are not being rewritten correctly inside multiple background images property with css variables
2 participants