Skip to content

How to review the forked pull requests

Jump to bottom Edit New page
Yosuke Leo Hara edited this page Jul 12, 2018 · 4 revisions

Prerequisites

Given that we've used CCI(Circle CI) as our CI infrastructure for integration tests (we've also used Travis CI for unit tests) and also used environment variables(EVs) on some jobs to keep those secret, we never be able to expose EVs by enabling Pass secrets to builds from forked pull requests on Advanced Settings at circleci.com (web UI).

Procedure to review

  • Evaluate each PR manually in order to check whether there is no security risks in the PR (especially in .circleci/config.yml)
  • Once it turns out that there are nothing such risks, Copy the PR branch into your local workspace
  • Push the PR branch into our official repository (leo-project/leofs)
  • CCI will start its workflow and the progress will be displayed on the PR page at github.com
  • Once every test suites passed on both CI services, please start the usual code review process

LeoProject/LeoFS is sponsored by Rakuten, Inc. and supported by Rakuten Institute of Technology.

Add a custom sidebar
Clone this wiki locally