Remove channels label fetching in useBaseSearch composable #12877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Learn
Build Artifacts
|
nucleogenesis
approved these changes
Nov 22, 2024
| @@ -443,14 +410,14 @@ describe(`useSearch`, () => { | |||
| it('should not remove any other filters', () => { | |||
| const { removeFilterTag, router } = prep({ | |||
| categories: 'test1,test2', | |||
| channels: 'channel1', | |||
| learning_activities: 'watch', | |||
There was a problem hiding this comment.
Curious why specifically watch here?
There was a problem hiding this comment.
There's no specific reason other than seeing it being used higher up in this testing file and using it to replace the filter that was previously there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request supports the removal of the 'channels' label from
SearchFiltersPaneland the corresponding label processing for the 'channels' option used in theuseBaseSearchcomposable, in addition to updating the relevant tests.References
Closes #12841
Reviewer guidance
Confirm that
useBaseSearchno longer exposesavailableChannelsand doesn't handle anything related to the 'channels' label.useBaseSearchshould still filter search results based on the channel the user is currently in.