Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to be enabled, disabled, and applied via env vars. #12844

Merged

Conversation

rtibbles
Copy link
Member

Summary

  • Adds environment variables to allow applying, enabling, and disabling plugins via a comma separated list of plugin names.

References

No actual issue for this, but has something that has come up a few times to make deployment for BCK easier, and also for enabling plugins for use in our Kolibri Apps.

Reviewer guidance

Test out each of the new environment variables.

I also thought I saw an issue where the environment variable set enabled plugins got saved to the plugin configuration when a Kolibri upgrade occurred - but I wasn't able to replicate on further testing.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added DEV: distributions Windows, Debian, PyPi, whl files, etc TAG: cloud Issues specific to running Kolibri in a cloud environment labels Nov 14, 2024
@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Nov 14, 2024
@marcellamaki marcellamaki self-assigned this Nov 19, 2024
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code read through makes sense, and a fair number of permutations of manual QA indicate this is working as expected

@rtibbles rtibbles merged commit 849b382 into learningequality:develop Nov 21, 2024
35 checks passed
@rtibbles rtibbles deleted the plugins_for_the_environment branch November 21, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... DEV: distributions Windows, Debian, PyPi, whl files, etc TAG: cloud Issues specific to running Kolibri in a cloud environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants