Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SearchFiltersPanel for Coach #12759

Merged
merged 28 commits into from
Nov 14, 2024
Merged

Update SearchFiltersPanel for Coach #12759

merged 28 commits into from
Nov 14, 2024

Commits on Nov 13, 2024

  1. conditionalize SearchFiltersPanel's mode of display: accordion or not

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f78ec82 View commit details
    Browse the repository at this point in the history

  2. DONOTMERGE: make button for testing in resource selection panel; I sk… 

    …ipped linting so this won't be merged by accident
    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9ba200e View commit details
    Browse the repository at this point in the history

  3. styling fixes/updates to better reflect designs

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    065cea6 View commit details
    Browse the repository at this point in the history

  4. incl activity buttons, fix icon error using existing (but incorrect) … 

    …icons
    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    dea67e4 View commit details
    Browse the repository at this point in the history

  5. tabindex=-1 for KIconButton chevron in AccordionItem

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    15a8420 View commit details
    Browse the repository at this point in the history

  6. need to call search if terms preexist 

    use kcheckbox not radio

better checkbox handling
    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    f8463be View commit details
    Browse the repository at this point in the history

  7. actiivtybuttonsgroup dynamic grid flow styling 

    handle radio selection correctly

proper icon color in category modals
    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3b5c6db View commit details
    Browse the repository at this point in the history

  8. handle show resources/needs

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    e576f4f View commit details
    Browse the repository at this point in the history

  9. move conditional positioning rendering from SidePanelsFilter to parents

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    fe02d5e View commit details
    Browse the repository at this point in the history

  10. styles fix & add uncategorized button

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    3678ed2 View commit details
    Browse the repository at this point in the history

  11. pass disabled prop to the button in the new accordionitem

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    1a7d8f7 View commit details
    Browse the repository at this point in the history

  12. improved logic for disabled/header appearance business

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    a8b18e6 View commit details
    Browse the repository at this point in the history

  13. remove drop-shadow add fineline 1px border on new accordion container

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    4d8d727 View commit details
    Browse the repository at this point in the history

  14. remove unnecessary code

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c7d4589 View commit details
    Browse the repository at this point in the history

  15. conditional KModal / div display for categories selection modal & cle… 

    …an up
    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    5009fc0 View commit details
    Browse the repository at this point in the history

  16. toggle uncategorized button

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    1121761 View commit details
    Browse the repository at this point in the history

  17. add hacky all_channels option

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    2060260 View commit details
    Browse the repository at this point in the history

  18. just emit empty object for all channels selection

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    13f4ecd View commit details
    Browse the repository at this point in the history

  19. remove channels option from searchfilterspanel accordion display

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    d2a2b82 View commit details
    Browse the repository at this point in the history

  20. remove channels from all SearchFiltersPanel

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    8b94f83 View commit details
    Browse the repository at this point in the history

  21. fix tests to accomodate new SearchFiltersPanel usage in LibraryPage

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    73b85ec View commit details
    Browse the repository at this point in the history

  22. cannot call coreString in component definition, default placehodler t… 

    …o null
    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    dc86215 View commit details
    Browse the repository at this point in the history

  23. side panel conditionals set correctly in LibraryPage

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c1fc917 View commit details
    Browse the repository at this point in the history

  24. side panel conditionals set correctly in LibraryPage pt2

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b30f7c5 View commit details
    Browse the repository at this point in the history

  25. ensure we unset the sidepanelisopen var when screensize changes

    @nucleogenesis
    nucleogenesis committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    c673a02 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. remove testing-only search button; hide activities in coach

    @nucleogenesis
    nucleogenesis committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d3ad0f9 View commit details
    Browse the repository at this point in the history

  2. pass topic ref as descendant when init'ing useBaseSearch in resources… 

    …election; search unconditionally
    @nucleogenesis
    nucleogenesis committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    51f196c View commit details
    Browse the repository at this point in the history

  3. call search in setup, not created, in LibraryPage

    @nucleogenesis
    nucleogenesis committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d16bebf View commit details
    Browse the repository at this point in the history